Properly support PEP 695 generics syntax #11189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reword relevant docstrings and comments.
Deploying pydantic-docs with
|
| Latest commit: |
308670a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bea518c3.pydantic-docs.pages.dev |
| Branch Preview URL: | https://pep695-support.pydantic-docs.pages.dev |
It was added for coverage purposes, but is fragile because it tests the implementation, not the functionality. As a consequence, it broke with the added logic in `parent_frame_namespace`. `test_module_ns_is_none` was rewritten to be self-contained.
CodSpeed Performance ReportMerging #11189 will not alter performanceComparing Summary
|
Viicos
force-pushed
the
pep695-support
branch
from
ea6f387 to
6294423
Compare
Coverage report
This PR does not seem to contain any modification to coverable code. |
Viicos
commented
Dec 30, 2024
There was a problem hiding this comment.
Best to be reviewed visually. The example was simplified a bit (avoid using lists, etc)
sydney-runkle
added
topic-type checking
sydney-runkle
approved these changes
Dec 30, 2024
Viicos
force-pushed
the
pep695-support
branch
from
0ad7a5c to
308670a
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit per commit.
Reword relevant docstrings and comments.
Fixes #11031.
Fixes #9782.
Change Summary
Related issue number
Checklist