Fix url serialization for unions #11233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, we've made the serialization for url types more strict. If a non-url type is passed into the serializer, we raise an unexpected value warning instead of just blindly attempting to stringify the input. This results in more intuitive behavior for serializing unions with url types.
Viicos
approved these changes
Jan 8, 2025
|
Will merge pending tests passing. |
CodSpeed Performance ReportMerging #11233 will degrade performances by 5.6%Comparing Summary
Benchmarks breakdown
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking 5d92c05