Improve performance of _typing_extra module
#11255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
6f56712
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e27b80b8.pydantic-docs.pages.dev |
| Branch Preview URL: | https://typing-extra-perf.pydantic-docs.pages.dev |
Viicos
force-pushed
the
typing-extra-perf
branch
from
9dc2303 to
48fc1d3
Compare
CodSpeed Performance ReportMerging #11255 will not alter performanceComparing Summary
|
Viicos
force-pushed
the
typing-extra-perf
branch
from
48fc1d3 to
c219e23
Compare
Viicos
commented
Jan 10, 2025
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
pydantic/_internal/_typing_extra.py
Outdated
| @@ -58,7 +40,7 @@ def is_any(tp: Any, /) -> bool: | |||
| #> True | |||
| ``` | |||
| """ | |||
| return _is_typing_name(tp, name='Any') | |||
| return tp is typing.Any or tp is t_e.Any | |||
There was a problem hiding this comment.
I wonder if it's worth importing everything by name and avoiding the attribute access, in my test it reduced the time from about 30ns to 20ns?
sydney-runkle
added
relnotes-performance
sydney-runkle
approved these changes
Jan 10, 2025
sydney-runkle
pushed a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
Checklist