Fix EmailStr for Cython #1126
Merged
Fix EmailStr for Cython #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
======================================
Coverage 100% 100%
======================================
Files 20 20
Lines 3431 3433 +2
Branches 663 664 +1
======================================
+ Hits 3431 3433 +2
Continue to review full report at Codecov.
|
koxudaxi
commented
Dec 26, 2019
Comment on lines
-301
to
308
| yield str_validator | ||
| yield cls.validate | ||
|
|
||
| @classmethod | ||
| def validate(cls, value: str) -> 'NameEmail': | ||
| def validate(cls, value: Any) -> 'NameEmail': | ||
| if type(value) == cls: | ||
| return value | ||
| value = str_validator(value) | ||
| return cls(*validate_email(value)) |
There was a problem hiding this comment.
Looks good, could you please also fix NameEmail and add a test for that too.
I found a bug that the validator can't parse NameEmail.
It means NameEmail filed doesn't accept an instance of NameEmail
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
|
great thank you. |
andreshndz
pushed a commit
to cuenca-mx/pydantic
that referenced
this pull request
Jan 17, 2020
* Fix EmailStr for Cython * add a change document. * Fix NameEmail * Update changes/1126-koxudaxi.md Co-Authored-By: Samuel Colvin <samcolvin@gmail.com> * Update pydantic/networks.py Co-Authored-By: Samuel Colvin <samcolvin@gmail.com> * Update changes/1126-koxudaxi.md Co-Authored-By: Samuel Colvin <samcolvin@gmail.com> * Update pydantic/networks.py Co-Authored-By: Samuel Colvin <samcolvin@gmail.com> Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR fixes EmailStr which is in Compiled Pydantic binary.
Related issue number
#1070
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)