Skip to content

Conversation

sydney-runkle
Copy link
Contributor

Cherry picking #11330

Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #11331 will degrade performances by 29.84%

Comparing patch-url-ser-fix (fb6e98f) with main (55dd8da)

🎉 Hooray! pytest-codspeed just leveled up to 2.2.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 34 regressions
✅ 9 untouched benchmarks
⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ test_getattr 54.1 µs N/A N/A
⁉️ test_setattr 86.1 µs N/A N/A
test_schema_build 2.9 ms 3.3 ms -13.37%
test_fastapi_startup_perf 200.1 ms 250.7 ms -20.2%
test_fastapi_startup_perf 26.2 ms 30.6 ms -14.49%
test_complex_model_schema_generation 1.8 ms 2.6 ms -29.84%
test_construct_dataclass_schema 1.8 ms 2.2 ms -16.93%
test_lots_of_models_with_lots_of_fields 2.7 s 3.3 s -19.1%
test_model_validators_serializers 917.8 µs 1,035.5 µs -11.37%
test_nested_model_schema_generation 1.1 ms 1.3 ms -11.11%
test_recursive_model_schema_generation 1 ms 1.3 ms -18.89%
test_simple_model_schema_generation 745.9 µs 893.8 µs -16.54%
test_simple_model_schema_lots_of_fields_generation 28.5 ms 38.5 ms -26.03%
test_tagged_union_with_callable_discriminator_schema_generation 1.5 ms 1.9 ms -24.08%
test_tagged_union_with_str_discriminator_schema_generation 1.5 ms 1.8 ms -12.69%
test_deeply_nested_recursive_model_schema_generation 1.3 ms 1.5 ms -13.43%
test_generic_recursive_model_schema_generation 896.1 µs 1,064.5 µs -15.83%
test_nested_recursive_generic_model_schema_generation 1.7 ms 2.1 ms -21.48%
test_nested_recursive_model_schema_generation 1.8 ms 2.2 ms -16.39%
test_recursive_discriminated_union_with_base_model 1.7 ms 2 ms -14.04%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  networks.py 477-479
Project Total  

This report was generated by python-coverage-comment-action

@sydney-runkle sydney-runkle merged commit 4160826 into v2.10-patches Jan 23, 2025
54 of 55 checks passed
@sydney-runkle sydney-runkle deleted the patch-url-ser-fix branch January 23, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant