Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Jan 29, 2025

Follow up on #11355.

Closes #10873, closes #11320, closes #9946, closes #8785, closes #8346, closes #8073, closes #8021.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jan 29, 2025
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #11356 will not alter performance

Comparing typealias-recursionerror (7b4cecd) with main (05daaa9)

Summary

✅ 45 untouched benchmarks

@Viicos Viicos force-pushed the typealias-recursionerror branch from 240c601 to 0975a01 Compare January 29, 2025 18:06
Copy link

cloudflare-workers-and-pages bot commented Jan 29, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7b4cecd
Status: ✅  Deploy successful!
Preview URL: https://0ca9c0a2.pydantic-docs.pages.dev
Branch Preview URL: https://typealias-recursionerror.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the typealias-recursionerror branch 2 times, most recently from 9df39e5 to 1f7a5f1 Compare January 29, 2025 19:57
@Viicos Viicos force-pushed the typealias-recursionerror branch from 1f7a5f1 to 3103c2f Compare January 29, 2025 20:04
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is helpful.

@Viicos Viicos enabled auto-merge (squash) February 1, 2025 10:27
@Viicos Viicos merged commit 54710a1 into main Feb 1, 2025
52 checks passed
@Viicos Viicos deleted the typealias-recursionerror branch February 1, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
2 participants