Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Jan 30, 2025

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jan 30, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c4ad6b2
Status: ✅  Deploy successful!
Preview URL: https://fa535e72.pydantic-docs.pages.dev
Branch Preview URL: https://core-2-28-0.pydantic-docs.pages.dev

View logs

@Viicos Viicos requested a review from sydney-runkle January 30, 2025 18:02
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #11364 will improve performances by 21.98%

Comparing core-2-28-0 (c4ad6b2) with main (8fe3aae)

Summary

⚡ 3 improvements
✅ 42 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_north_star_validate_json 49.8 ms 40.8 ms +21.98%
test_north_star_validate_json_strict 49.6 ms 40.8 ms +21.67%
test_north_star_validate_python_strict 23.8 ms 22.5 ms +5.61%

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  version.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit 4a7ec17 into main Jan 30, 2025
55 checks passed
@Viicos Viicos deleted the core-2-28-0 branch January 30, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants