Skip to content

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jan 2, 2020

Change Summary

  • Move version_info() to version.py (still usable from utils.py for backwards compatibility).
  • Change issue templates to use version_info() not it's been released for a while

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #1138 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1138   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          20      20           
  Lines        3445    3445           
  Branches      665     665           
======================================
  Hits         3445    3445
Impacted Files Coverage Δ
pydantic/version.py 100% <100%> (ø) ⬆️
pydantic/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cac47...0b4b699. Read the comment docs.

@samuelcolvin samuelcolvin merged commit e169bd6 into master Jan 2, 2020
@samuelcolvin samuelcolvin deleted the use-version-info branch January 2, 2020 19:34
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this pull request Jan 17, 2020
* encourage use of version_info() in issues

* improve grammar and add change

* switch test import
RajatRajdeep pushed a commit to RajatRajdeep/pydantic that referenced this pull request May 14, 2024
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant