Expose fallback parameter in serialization methods
#11398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
1cd0bc2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4823e9d6.pydantic-docs.pages.dev |
| Branch Preview URL: | https://fallback.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11398 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
approved these changes
Feb 7, 2025
Merged
4 tasks
jdeschamps
added a commit
to CAREamics/careamics
that referenced
this pull request
May 5, 2025
…#465) ## Description <!-- This section provides the necessary background and information for reviewers to understand the code and have the correct mindset when examining changes. --> > [!NOTE] > **tldr**: Pydantic `BaseModel.model_dump` function signature in 2.11 is not back compatible with 2.10. This PR sets the Pydantic lower bound version to 2.11 and bumps the upper bound to 2.12. ### Background - why do we need this PR? The reason we need this PR is because we override the `model_dump` method in the `Configuration` class. Pydantic 2.11 introduces a new `fallback` argument and also changes the type of `by_alias` to `bool | None` from `bool`. These were introduced in the PRs pydantic/pydantic#11398 and pydantic/pydantic#11468 respectively. If we do not update the function signature mypy tells us that we have overridden the function in a way that is incompatible with the base class, if we do update the signature it is no longer compatible with Pydantic 2.10. I have updated the signature so we can continue to use newer versions of Pydantic. ### Overview - what changed? Updated `pyproject.toml` and `Configuration.model_dump`. ## Breaking changes This will cause the same backwards compatibility issue in CAREamics as Pydantic, but it should not break existing code. --- **Please ensure your PR meets the following requirements:** - [x] Code builds and passes tests locally, including doctests - [x] New tests have been added (for bug fixes/features) - [x] Pre-commit passes - [ ] PR to the documentation exists (for bug fixes / features) Co-authored-by: Joran Deschamps <6367888+jdeschamps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Closes #11381.
Related issue number
Checklist