Skip to content

Allow generic typed dictionaries to be used for unpacked variadic keyword parameters #11571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

Allow generic typed dictionaries to be used for unpacked variadic keyword parameters #11571

merged 1 commit into from
Mar 18, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Mar 17, 2025

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos requested a review from davidhewitt March 17, 2025 16:14
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Mar 17, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 17, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a010b81
Status: ✅  Deploy successful!
Preview URL: https://940530c4.pydantic-docs.pages.dev
Branch Preview URL: https://generic-unpack.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11571 will not alter performance

Comparing generic-unpack (a010b81) with main (d76d942)

Summary

✅ 46 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit 9ebcf01 into main Mar 18, 2025
62 checks passed
@Viicos Viicos deleted the generic-unpack branch March 18, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viicos @davidhewitt