Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Mar 18, 2025

Fixes #11574.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

…g cached properties and self-referenced models
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Mar 18, 2025
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0ca8d15
Status: ✅  Deploy successful!
Preview URL: https://e6a5f038.pydantic-docs.pages.dev
Branch Preview URL: https://cached-property-recursive-re.pydantic-docs.pages.dev

View logs

@Viicos Viicos requested a review from davidhewitt March 18, 2025 18:21
Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #11579 will not alter performance

Comparing cached-property-recursive-repr (0ca8d15) with main (a2846da)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  main.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos removed the request for review from davidhewitt March 19, 2025 22:32
@Viicos Viicos merged commit 69b2b63 into main Mar 19, 2025
63 checks passed
@Viicos Viicos deleted the cached-property-recursive-repr branch March 19, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Displaying a parent-child tree of models with a computed cached_property causes a RuntimeError
2 participants