Fix deferred discriminator application logic #11591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
d7523cc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f349ce6c.pydantic-docs.pages.dev |
| Branch Preview URL: | https://deferred-disc-cleanup.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11591 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
We forgot to remove the discriminator metadata info when cleaning schemas, and this led to critical issues when such schemas are referenced in other places as the deferred discriminator application logic would happen twice.
Viicos
force-pushed
the
deferred-disc-cleanup
branch
from
de5bb84 to
d7523cc
Compare
davidhewitt
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to remove the discriminator metadata info when cleaning schemas, and this led to critical issues when such schemas are referenced in other places as the deferred discriminator application logic would happen twice.
Fixes #11587.
Change Summary
Related issue number
Checklist