Skip to content

Do not override 'definitions-ref' schemas containing serialization schemas or metadata #11644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

Do not override 'definitions-ref' schemas containing serialization schemas or metadata #11644

merged 2 commits into from
Mar 28, 2025
+46 −2

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Mar 28, 2025

Fixes #11642.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Mar 28, 2025
@Viicos Viicos force-pushed the resolve-defs-issue branch from d404c5f to 53774f3 Compare March 28, 2025 14:15
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 28, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0261b45
Status: ✅  Deploy successful!
Preview URL: https://98da30f0.pydantic-docs.pages.dev
Branch Preview URL: https://resolve-defs-issue.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the resolve-defs-issue branch from 53774f3 to 0b747aa Compare March 28, 2025 14:15
@Viicos Viicos force-pushed the resolve-defs-issue branch from 0b747aa to 0e96db2 Compare March 28, 2025 14:16
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11644 will not alter performance

Comparing resolve-defs-issue (0261b45) with main (58e61fa)

Summary

✅ 46 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit 1dcddac into main Mar 28, 2025
62 checks passed
@Viicos Viicos deleted the resolve-defs-issue branch March 28, 2025 14:52
@zzstoatzz zzstoatzz mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PlainSerializer does not work correctly in 2.11
2 participants
@Viicos @dmontagu