Skip to content

Conversation

parth-paradkar
Copy link
Contributor

@parth-paradkar parth-paradkar commented Apr 4, 2025

Change Summary

Fixes the ImportError message for email-validator to use single quotes are required. Ref- https://docs.pydantic.dev/latest/install/#install-from-repository

Related issue number

Trivial change, no issue created

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@parth-paradkar
Copy link
Contributor Author

please review

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Apr 4, 2025
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Performance Report

Merging #11695 will not alter performance

Comparing parth-paradkar:fix-import-error-message (082504b) with main (bd1f8cf)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  networks.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos added relnotes-ignore Omit this PR from the release notes. and removed ready for review relnotes-fix Used for bugfixes. labels Apr 8, 2025
@Viicos Viicos merged commit a43b346 into pydantic:main Apr 8, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants