-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Dify third-party tests #11719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dify third-party tests #11719
Conversation
CodSpeed Performance ReportMerging #11719 will not alter performanceComparing Summary
|
ab270cd to
39503c9
Compare
|
Hi @sydney-runkle, would you like to help adding |
5c56588 to
9d84350
Compare
|
Hello @bowenliang123, thanks for the PR. As per our policy for third-party tests, could you provide info about your project and how Pydantic is being used?
Thanks |
9d84350 to
23bd98c
Compare
Hi @Viicos , thanks for the review.
|
aa7b40d to
9f0ce31
Compare
|
In this case, we would normally not include it in third party tests, simply because we don't expect regressions to happen if Pydantic is mostly used the intended way. The test suite doesn't seem to take long to run though, so if you can confirm me that your CI workflow won't change too much over time, I'm willing to include it. Note that you have a bunch of warnings in tests: https://github.com/pydantic/pydantic/actions/runs/14512680436/job/40714766670?pr=11719. Pytest should error on these so maybe you disabled it, but I would suggest taking a look at them before things start breaking. |
|
OK, thanks for the reply. I'm closing this PR this time as you suggested. |
Looks like you missed this part ^? |
9f0ce31 to
07a3053
Compare
|
Hi @Viicos , thanks for your reminder. I have reopened this PR, and rebased my changes on to the latest commit of the main branch. The third party tests for Dify has passed, while the failed tests are from BentoML, not part of my changes. |
Can you please confirm the above? |
|
Yes. The testing execution time is reaonablely short, which mainly consists of the dependency installation time with uv taking about 15s and the unit tests execution time for less than a minute. |
|
Yes but I'm more asking if your CI workflow is subject to changes in the future, as this requires us to fix it whenever something changes on your end (for instance, this is what I suspect is happening with BentoML). |
|
We have put all the unit tests (other than the integration tests relying on outter services) under the single testing script. So I would see it won't be changed often. And the unit tests have covered the usage of Pydantics in model declaration , construction and the configs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bowenliang123
Change Summary
Related issue number
Checklist