Skip to content

Conversation

fhightower
Copy link
Contributor

@fhightower fhightower commented Apr 8, 2025

Hello! I assume this is trivial enough to not require an issue/discussion, but happy to raise an issue if desired.

Change Summary

Update the note on datetime_from_date_parsing which was referencing an old version of pydantic as if it is yet to be released.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@fhightower
Copy link
Contributor Author

please review - thanks!

Copy link
Contributor

hyperlint-ai bot commented Apr 8, 2025

PR Change Summary

Updated documentation to reflect that support for parsing datetimes from specific date formats has already been released in a previous version.

  • Revised note in the validation errors documentation regarding datetime parsing support
  • Clarified that support for parsing datetimes from 'yyyy-MM-DD' dates was added in version 2.6.0

Modified Files

  • docs/errors/validation_errors.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

Copy link

codspeed-hq bot commented Apr 8, 2025

CodSpeed Performance Report

Merging #11722 will not alter performance

Comparing fhightower:remove-old-docs-warning (e8b1a48) with main (2e7cddb)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we can just remove the note entirely.

@Viicos Viicos changed the title Update note for datetime_from_date_parsing to reflect that this has already been released Remove unecessary note in errors documentation Apr 11, 2025
@Viicos Viicos added the relnotes-ignore Omit this PR from the release notes. label Apr 11, 2025
@Viicos Viicos merged commit 121651b into pydantic:main Apr 13, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants