Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented May 2, 2025

Fixes #11805.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos requested a review from DouweM May 2, 2025 10:59
@Viicos Viicos force-pushed the docstring-extraction-313 branch from f95449d to 031251b Compare May 2, 2025 10:59
Copy link

cloudflare-workers-and-pages bot commented May 2, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 620919d
Status: ✅  Deploy successful!
Preview URL: https://a4aee606.pydantic-docs.pages.dev
Branch Preview URL: https://docstring-extraction-313.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the docstring-extraction-313 branch from 031251b to 620919d Compare May 2, 2025 11:00
@Viicos Viicos added relnotes-change Used for changes to existing functionality which don't have a better categorization. and removed documentation labels May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  dataclasses.py
  pydantic/_internal
  _docs_extraction.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link

codspeed-hq bot commented May 2, 2025

CodSpeed Performance Report

Merging #11829 will not alter performance

Comparing docstring-extraction-313 (620919d) with main (15a4faa)

Summary

✅ 46 untouched benchmarks

@Viicos Viicos merged commit 3382fb1 into main May 9, 2025
63 checks passed
@Viicos Viicos deleted the docstring-extraction-313 branch May 9, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-change Used for changes to existing functionality which don't have a better categorization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when use_attribute_docstrings=True, DocstringVisitor fail to grab field docs in unknown reason when using
2 participants