Do not delete mock validator/serializer in model_rebuild()
#11890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pydantic-core` won't use them anyway as it checks for `__pydantic_complete__` first. This is done in order to avoid concurrency issues, where a concurrent model instantiation would use the validator from a parent class if the `model_rebuild()` call haven't finished in another thread.
Deploying pydantic-docs with
|
| Latest commit: |
42175f7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9bc7b193.pydantic-docs.pages.dev |
| Branch Preview URL: | https://rebuild-mock.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11890 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
Does this mean that multiple threads might start rebuilding at the same time? Such a race seems not ideal. |
|
Yes, but this was already the case before 2.11. It isn't ideal as it can result in multiple unnecessary rebuilds, but seems like this is somewhat safe as we got no reports about this before. |
hramezani
approved these changes
May 21, 2025
5 tasks
Viicos
added a commit
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pydantic-corewon't use them anyway as it checks for__pydantic_complete__first. This is done in order to avoid concurrency issues, where a concurrent model instantiation would use the validator from a parent class if themodel_rebuild()call did not finish in another thread.Change Summary
Fixes #11849, regression in #11429, alternative to #11851.
Related issue number
Checklist