Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented May 26, 2025

Change Summary

Fixes #11912.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 26, 2025
Copy link

cloudflare-workers-and-pages bot commented May 26, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58a4ea2
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

github-actions bot commented May 26, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  types.py 1171
  pydantic/_internal
  _fields.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link

codspeed-hq bot commented May 26, 2025

CodSpeed Performance Report

Merging #11914 will not alter performance

Comparing deprecated-method-defaults (58a4ea2) with main (f0e1d04)

Summary

✅ 46 untouched benchmarks

@Viicos Viicos enabled auto-merge (squash) June 12, 2025 19:50
@Viicos Viicos requested a review from DouweM June 13, 2025 08:50
@Viicos Viicos merged commit 638d047 into main Jun 13, 2025
56 of 57 checks passed
@Viicos Viicos deleted the deprecated-method-defaults branch June 13, 2025 15:55
@yiphei
Copy link

yiphei commented Jun 22, 2025

@Viicos i didnt see this fix being in the latest release. how do you your releases work? just curious, also because I want to get this fix into my dev environment

@Viicos
Copy link
Member Author

Viicos commented Jun 22, 2025

This will be released in 2.12, which we'll push during the summer.

@yiphei
Copy link

yiphei commented Jun 30, 2025

@Viicos to avoid asking you in the future, how can i find out which release a fix will be pushed to?

@Viicos
Copy link
Member Author

Viicos commented Jun 30, 2025

If you check the commit that was created to merge the PR to main (in this case 638d047), you can check the tags that include that commit. For this one, because it wasn't included in any release yet, it is empty:

image

This is how it looks for a commit that was released:

image

Alternatively, lookup the changelog for the PR number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a field named schema results in the @schema property being sneakily added as the default value
3 participants