Do not implicitly convert after model validators to class methods #11957
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
added
relnotes-change
5 tasks
Viicos
force-pushed
the
no-classmethod-aftervalidator
branch
from
b2ee66f to
7620df4
Compare
Deploying pydantic-docs with
|
| Latest commit: |
8a074b4
|
| Status: | ⚡️ Build in progress... |
CodSpeed Performance ReportMerging #11957 will not alter performanceComparing Summary
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
DouweM
approved these changes
Jun 12, 2025
DouweM
reviewed
Jun 12, 2025
Viicos
added
the
needs-blogpost-entry
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #11905, closes #11906.
Technically this is a breaking change since the signature from the added test was unexpectedly working, but this wasn't documented at all and the fix is straightforward. What do you think?
Need to document the change (see #12110) in blog post and changelog.
Related issue number
Checklist