Skip to content

Conversation

lukland
Copy link
Contributor

@lukland lukland commented Jun 25, 2025

Change Summary

Uncomment Makefile first line to be compliant with the docs/contributing.md

Related issue number

Fixes #11996

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @DouweM

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jun 25, 2025
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Performance Report

Merging #12015 will not alter performance

Comparing lukland:fix/contributing-doc-make-target (95531ae) with main (188dc9a)

Summary

✅ 46 untouched benchmarks

@lukland
Copy link
Contributor Author

lukland commented Jun 25, 2025

Very small change to be compliant with the documentation, please review

@lukland lukland marked this pull request as ready for review June 25, 2025 16:23
@DouweM
Copy link
Contributor

DouweM commented Jun 25, 2025

@lukland Thanks, I had noticed this too but shamefully never fixed it. @Viicos Makes sense to you?

@DouweM DouweM assigned Viicos and unassigned DouweM Jun 25, 2025
@Viicos Viicos changed the title Fix: default target of Makefile Set back default target of Makefile Jun 26, 2025
@Viicos Viicos added relnotes-ignore Omit this PR from the release notes. and removed ready for review relnotes-fix Used for bugfixes. labels Jun 26, 2025
@Viicos
Copy link
Member

Viicos commented Jun 26, 2025

Thanks @lukland, makes sense!

@Viicos Viicos merged commit 42298a0 into pydantic:main Jun 26, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile default target
3 participants