Skip to content

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Sep 1, 2025

Change Summary

Similar to #12207, but for the v2 mypy plugin.
Seems my tests didn't trigger that part which is why I missed it earlier.

Some background: python/mypy#19768 (comment)

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @Viicos

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 1, 2025
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  mypy.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link

codspeed-hq bot commented Sep 1, 2025

CodSpeed Performance Report

Merging #12209 will not alter performance

Comparing cdce8p:fix-mypy-plugin (3daa7b7) with main (0054305)

Summary

✅ 46 untouched benchmarks

@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 1, 2025

please review

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again

@Viicos Viicos merged commit 62d70d1 into pydantic:main Sep 1, 2025
63 checks passed
@cdce8p cdce8p deleted the fix-mypy-plugin branch September 1, 2025 16:10
@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 4, 2025

Are there any plans to do a new release soon?

The next mypy version is expected to be released next week. See python/mypy#19764 (comment)
There is also the Python 3.14 support which would be awesome to have in a production release. This would allow downstream packages and applications to start adding compatibility themselves.

@Viicos
Copy link
Member

Viicos commented Sep 5, 2025

While a bit tight, we should be able to come with a final 2.12 release beginning of October, so right before the 3.14 release. I'll kick a beta release in a couple release, so that it can at least be used with mypy in the meanwhile.

@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 5, 2025

Thanks for the update!

@DanielNoord
Copy link
Contributor

Is there any chance this can be backported to the 2.11 branch? mypy is reporting significant performance gains in this release and we'd like to start using that as soon as possible.

This seems like a small enough change to backport?

@Viicos
Copy link
Member

Viicos commented Sep 13, 2025

Is there any chance this can be backported to the 2.11 branch? mypy is reporting significant performance gains in this release and we'd like to start using that as soon as possible.

This seems like a small enough change to backport?

Yeah given that mypy 1.18 got released already, I think it makes sense.

Viicos pushed a commit that referenced this pull request Sep 13, 2025
@Viicos
Copy link
Member

Viicos commented Sep 13, 2025

@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 13, 2025

Thanks for new releases @Viicos!

Unfortunately, v1/mypy.py is still broken though. Seems #12207 wasn't merged back into the v2.11-fixes branch beforehand.

@Viicos
Copy link
Member

Viicos commented Sep 13, 2025

My bad, such backporting happens so rarely that it is done manually, so this was bound to happen 😅

Published 2.11.9.

@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 13, 2025

No problem. Thanks again! One last thing. Would you mind approving the workflow so the version is actually pushed to PyPI?
https://github.com/pydantic/pydantic/actions/runs/17695540042

@DanielNoord
Copy link
Contributor

Thanks @Viicos @cdce8p.

It is not common for packages to go out of their way to expedite patch releases for such small fixes, and I know how annoying it can be to do so.

Highly appreciated that you did so. By me, but likely by many others!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants