-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix mypy v2 plugin for upcoming mypy release #12209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
CodSpeed Performance ReportMerging #12209 will not alter performanceComparing Summary
|
|
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again
|
Are there any plans to do a new release soon? The next mypy version is expected to be released next week. See python/mypy#19764 (comment) |
|
While a bit tight, we should be able to come with a final 2.12 release beginning of October, so right before the 3.14 release. I'll kick a beta release in a couple release, so that it can at least be used with mypy in the meanwhile. |
|
Thanks for the update! |
|
Is there any chance this can be backported to the This seems like a small enough change to backport? |
Yeah given that mypy 1.18 got released already, I think it makes sense. |
|
My bad, such backporting happens so rarely that it is done manually, so this was bound to happen 😅 Published 2.11.9. |
|
No problem. Thanks again! One last thing. Would you mind approving the workflow so the version is actually pushed to PyPI? |
Change Summary
Similar to #12207, but for the
v2mypy plugin.Seems my tests didn't trigger that part which is why I missed it earlier.
Some background: python/mypy#19768 (comment)
Related issue number
Checklist
Selected Reviewer: @Viicos