Remove typing-extension dependency on python 3.8 #1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3723 3723
Branches 735 735
=========================================
Hits 3723 3723 Continue to review full report at Codecov.
|
PrettyWood
force-pushed
the
remove-typing-extensions-3.8
branch
from
13d7cb2 to
23706d9
Compare
|
could you add an empty to commit to prompt another run of tests and check that failure was due to an intermittent error in pypi? |
|
otherwise looks good. |
|
@samuelcolvin all good ! |
|
😴 now something else is failing intermittently, really hope these problems are temporary. |
|
@samuelcolvin This time it's good. Sorry for the hasty ping |
|
thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove
typing_extensionsdependency for python 3.8Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)