add strip_whitespace option for ConstrainedStr and constr
#163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 910 918 +8
Branches 202 204 +2
=====================================
+ Hits 910 918 +8 |
|
@samuelcolvin updated, please check |
HISTORY.rst
Outdated
| @@ -7,6 +7,7 @@ v0.8.1 (2018-XX-XX) | |||
| ................... | |||
| * tweak email-validator import error message #145 | |||
| * fix parse error of parse_date() and parse_datetime() when input is 0 #144 | |||
| * **breaking change**: add ``Config.anystr_strip_whitespace`` and ``strip_whitespace`` kwarg to ``constr``, by default values is `True` #163 | |||
There was a problem hiding this comment.
Maybe best to make this False by default an avoid a breaking change.
Since this is easy for people to change and reuse that change throughout their projects I think it would be better to avoid the unnecessary breaking change?
There was a problem hiding this comment.
In my experience we always need to strip any string data during validation except passwords or tokens. Also many validation libraries use strip logic enabled by default. But you are the owner and I will do what you prefer.
There was a problem hiding this comment.
Let's use False by default, it's better for now. At first we will introduce to people new settings to control strip logic and maybe be in future we will switch to True.
There was a problem hiding this comment.
ok, makes sense. This would require a patch release anyway, so let's just go with this.
|
Thanks a lot, I'll try and merge a couple of other PRs which are finished and deploy in the next couple of days. |
|
And I will try to implement more things from #161 😃 |
* feat: add `default_factory` * we will not deepcopy default values * error message for bad default factory * bad default_factory should not raise ValidationError * tiny cleanup Co-authored-by: Samuel Colvin <s@muelcolvin.com>
No description provided.