Skip to content

Conversation

EdwardBetts
Copy link
Contributor

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #1960 (7053878) into master (bf9cc4a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master     #1960    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           21        21            
  Lines         3909      4133   +224     
  Branches       788       832    +44     
==========================================
+ Hits          3909      4133   +224     
Impacted Files Coverage Δ
pydantic/color.py 100.00% <100.00%> (ø)
pydantic/json.py 100.00% <0.00%> (ø)
pydantic/tools.py 100.00% <0.00%> (ø)
pydantic/types.py 100.00% <0.00%> (ø)
pydantic/utils.py 100.00% <0.00%> (ø)
pydantic/errors.py 100.00% <0.00%> (ø)
pydantic/fields.py 100.00% <0.00%> (ø)
pydantic/schema.py 100.00% <0.00%> (ø)
pydantic/typing.py 100.00% <0.00%> (ø)
pydantic/generics.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf9cc4a...7053878. Read the comment docs.

@samuelcolvin
Copy link
Member

Looks good to me.

Please add a change description and make sure tests are coving this case.

@samuelcolvin
Copy link
Member

bump

@samuelcolvin
Copy link
Member

@EdwardBetts any chance you could finish this?

@samuelcolvin samuelcolvin merged commit 58a6070 into pydantic:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants