Force fields.Undefined to be a singleton object #1981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviskirk
force-pushed
the
make-undefined-singleton
branch
2 times, most recently
from
f93f560 to
5401afe
Compare
Codecov Report
@@ Coverage Diff @@
## master #1981 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 42 42
Lines 7832 7850 +18
Branches 1576 1576
=======================================
+ Hits 7820 7838 +18
Misses 10 10
Partials 2 2
Continue to review full report at Codecov.
|
…he code, we compare directly to `fields.Undefined`since we assume it to be constant.When new models get created however, the object is deepcopied andis no longer identical with the original object.We therefore add `__copy__` and `__deepcopy__` methods to ensurethat the copied objects are actually the same original object.
daviskirk
force-pushed
the
make-undefined-singleton
branch
from
5401afe to
f50e6d1
Compare
|
great, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
In various places of the code, we compare directly to
fields.Undefinedsince we assume it to be constant.
When new models get created however, the object is deepcopied and
is no longer identical with the original object.
We therefore add
__copy__and__deepcopy__methods to ensurethat the copied objects are actually the same original object.
Related issue number
While I did does not address the exact error message #1578 had, schema generation on inherited generics that had required generic fields did not work at all, so it might also fix this.
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)