Allow arbitrary types in model #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
+ Coverage 99.84% 99.84% +<.01%
==========================================
Files 11 11
Lines 1285 1300 +15
Branches 235 237 +2
==========================================
+ Hits 1283 1298 +15
Misses 2 2 |
pydantic/validators.py
Outdated
| if arbitrary_types_allowed: | ||
| return [make_arbitrary_type_validator(type_)] | ||
| else: | ||
| raise errors.ConfigError(f'no validator found for {type_}') |
There was a problem hiding this comment.
This should be a RuntimeError, it's not a config problem and will happen at runtime.
Gr1N
reviewed
Jun 27, 2018
|
|
||
| with pytest.raises(ValidationError) as exc_info: | ||
| ArbitraryTypeAllowedModel(t=C()) | ||
| assert exc_info.value.errors() == [ |
There was a problem hiding this comment.
can you please test your changes with exc_info.value.json()? I don't think that ctx with type is JSON serializable. To my mind we need to use utils.display_as_type when we firing ArbitraryTypeError exception.
Gr1N
reviewed
Jun 27, 2018
| @@ -204,3 +204,10 @@ class UUIDVersionError(PydanticValueError): | |||
|
|
|||
| def __init__(self, *, required_version: int) -> None: | |||
| super().__init__(required_version=required_version) | |||
|
|
|||
|
|
|||
| class ArbitraryTypeError(PydanticTypeError): | |||
There was a problem hiding this comment.
I think for better readability we need to define code = 'type_error.arbitrary_type' or rename class to ArbitraryError
Closed
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* Allow functions within model_class validators * make fields_set flexible * improve coverage * fix error message test to support pypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #182