refactor: set Pattern encoder in ENCODERS_BY_TYPE
#2444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrettyWood
force-pushed
the
pattern-fastapi
branch
from
d18d5d6 to
7ff880b
Compare
|
@PrettyWood I switched from a label to a milestone for v1.8.1, I think that makes more sense. I'm not sure why this has been tagged as v1.8.1? |
|
@samuelcolvin It's not required for 1.8.1 but without it, the issue is not completely solved as it doesn't work for |
|
this is great, thank you. |
This was referenced Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Set
Patternencoder directly inENCODERS_BY_TYPEto be used byfastapiRelated issue number
#2045
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)