timedelta json encoding #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 1463 1478 +15
Branches 270 273 +3
=====================================
+ Hits 1463 1478 +15 |
samuelcolvin
force-pushed
the
timedelta-json-encoding
branch
from
d6c6bbc to
b620510
Compare
Gr1N
reviewed
Aug 20, 2018
| @@ -134,11 +136,16 @@ def __new__(mcs, name, bases, namespace): | |||
| ) | |||
|
|
|||
| vg.check_for_unused() | |||
| if config.json_encoders: | |||
There was a problem hiding this comment.
We can simplify 4 lines into one, because pydantic_encoder will be called inside custom_pydantic_encoder in case if custom encoder not found:
json_encoder = partial(custom_pydantic_encoder, config.json_encoders)
There was a problem hiding this comment.
Are we sure this won't be slow? I don't really know.
There was a problem hiding this comment.
Given that it's not much extra code and json_encoder could be called a lot, let's keep it like this.
Gr1N
reviewed
Aug 20, 2018
pydantic/json.py
Outdated
| return pydantic_encoder(obj) | ||
|
|
||
|
|
||
| def timedelta_isoformat(td: datetime.timedelta): |
|
Overall looks good to me. |
samuelcolvin
force-pushed
the
timedelta-json-encoding
branch
from
bd666a1 to
110c7e1
Compare
This was referenced Aug 25, 2018
Merged
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* build binaries for 3.11 * [full-build] remove 3.11 from windows builds * print commit message for debugging * try ci on push * trigger full build * trigger full build, try again * trigger full build, try again 2 * [skip ci] remove lint prints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an alternative to #220. Needs a few more tests and docs but otherwise complete.
basically, I've added a
json_encodersConfig settings, allowing custom typing encoding defined on a model:@Gr1N and @cfkanesan I'd appreciate your feedback on this.