Skip to content

Conversation

cwe5590
Copy link
Contributor

@cwe5590 cwe5590 commented Mar 14, 2021

Change Summary

Enable the Hypothesis plugin to generate a constrained decimal when the decimal_place argument is specified.

Related issue number

fix #2520

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #2524 (d1a121e) into master (619ff26) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2524   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         5109      5109           
  Branches      1050      1050           
=========================================
  Hits          5109      5109           
Impacted Files Coverage Δ
pydantic/_hypothesis_plugin.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619ff26...b42a709. Read the comment docs.

@cwe5590 cwe5590 changed the title Add decimal_places to a constrained decimal strategy Allow for generation of a constrained decimal with decimal_places argument for hypothesis plugin Mar 14, 2021
Copy link
Collaborator

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM! 👍

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>
Copy link
Collaborator

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samuelcolvin samuelcolvin merged commit 9cc6d44 into pydantic:master May 9, 2021
@samuelcolvin
Copy link
Member

awesome, thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants