New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support user defined generic field types in generic models for python < 3.9. #2554
Support user defined generic field types in generic models for python < 3.9. #2554
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2554 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5109 5109
Branches 1050 1050
=========================================
Hits 5109 5109
Continue to review full report at Codecov.
|
213500a
to
661c3b3
Compare
Work on pydantic#2465 (see comments)
661c3b3
to
38dce40
Compare
Rebased on master to fix tests |
thanks so much. |
Work on #2465 (see comments) Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Add support for user defined generic type fields in generic models for python < 3.9.
Referencing this comment (and the problem described) here: #2465 (comment)
Change Summary
The actual change (the check for
type_.name_
) is not necessary in python >= 3.9 as described in the code comment but is needed for python < 3.9.Related issue number
Work on #2465 (see comments)
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)