Support postgresql+asyncpg schema for PostgresDsn #2567

fike · 2021-03-23T01:00:02Z

Change Summary

SQLAchemy 1.4 added alpha support to async calls. The support to PostgreSQL needs to add asyncpg in the schema, e.g.: postgresql+asyncpg://scott:tiger@localhost/test

Related issue number

#2545
Closes #2679

Checklist

[ X ] Unit tests for the changes exist
[ X ] Tests pass on CI and coverage remains at 100%
[ X ] Documentation reflects the changes where applicable
[ X ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

codecov · 2021-03-23T01:01:58Z

Codecov Report

Merging #2567 (13b9237) into master (7b7e705) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 13b9237 differs from pull request most recent head d0a5f8d. Consider uploading reports for the commit d0a5f8d to get more accurate results

@@            Coverage Diff            @@
##            master     #2567   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         5109      5109           
  Branches      1050      1050           
=========================================
  Hits          5109      5109

Impacted Files	Coverage Δ
pydantic/networks.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5549e8d...d0a5f8d. Read the comment docs.

PrettyWood

Thanks!

Kludex · 2021-03-28T20:37:45Z

As we are already here... Can we add pg8000 as well? 😅

fike · 2021-03-29T12:42:47Z

As we are already here... Can we add pg8000 as well? 😅

Certainly! I'm changing of the computer, if can waiting for a few days until finish my setup and implement it. :D

fike · 2021-03-31T14:16:59Z

As we are already here... Can we add pg8000 as well? 😅

Hi @Kludex, I added pg8000 here. :)

docs/usage/types.md

Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>

PrettyWood

You can probably rebase on master too

changes/2567-postgres-asyncpg.md

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>

…o postgres_asyncpg

…gres_asyncpg

fike · 2021-04-06T02:28:59Z

You can probably rebase on master too

Hi @PrettyWood, can you check if I did right? I'm not confident that if my laptop migration didn't mess something.

PrettyWood

Just a suggestion for the change file to use ` and present. LGTM otherwise for the patch :)

changes/2567-postgres-asyncpg.md

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>

fike · 2021-04-07T21:18:01Z

Just a suggestion for the change file to use ` and present. LGTM otherwise for the patch :)

Thanks! :)

PrettyWood · 2021-04-19T21:08:34Z

Hey @fike
Seeing #2679, I wonder if we could just add all the dialects specified here
WDYT ?

fike · 2021-04-20T11:52:02Z

Hey @fike
Seeing #2679, I wonder if we could just add all the dialects specified here
WDYT ?

Yes, certainly! I'll do that. 👍

…gres_asyncpg

PrettyWood

Thanks!

docs/usage/types.md

changes/2567-postgres-asyncpg.md

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>

samuelcolvin

otherwise LGTM.

docs/usage/types.md

samuelcolvin · 2021-05-09T12:39:14Z

please update.

Co-authored-by: Samuel Colvin <samcolvin@gmail.com>

fike · 2021-05-09T14:04:39Z

please update.

I did. Thanks, @samuelcolvin. :)

PrettyWood · 2021-06-05T20:30:29Z

tests/test_networks.py

+        'postgresql+asyncpg://user:pass@localhost:5432/app',
+        'postgresql+pg8000://user:pass@localhost:5432/app',
+        'postgresql+psycopg2cffi://user:pass@localhost:5432/app',
+        'postgresql+py-postgresql://user:pass@localhost:5432/app',
+        'postgresql+pygresql://user:pass@localhost:5432/app',


All those tests would already be valid without your PR. You probably want to parametrize test_postgres_dsns

I did that but I'm sure if my implementation was good. It's wonderful anyone can review it. :)

docs/usage/types.md

PrettyWood · 2021-06-05T20:31:55Z

Please update and rebase/merge with master for CI to run properly. Sorry for reaching out so late. Thanks!

fike · 2021-07-25T17:33:34Z

@PrettyWood, can you check if I rebased correctly? :)

PrettyWood

Thanks!

@samuelcolvin

* Added suport to postgresql async driver * Added postgres+asyncpg in the doc. * Added changes file * Added postgresql+pg8000 schema * ran make format * Update docs/usage/types.md Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com> * Changed from schema to scheme Co-authored-by: Eric Jolibois <em.jolibois@gmail.com> * fixed typo scheme * fixed merge schema * changed to one line description Co-authored-by: Eric Jolibois <em.jolibois@gmail.com> * added others DBAPI dialects. * Added two # by PrettyWood Co-authored-by: Eric Jolibois <em.jolibois@gmail.com> * fix typo by PrettyWood Co-authored-by: Eric Jolibois <em.jolibois@gmail.com> * Fixed typo by PrettyWood Co-authored-by: Eric Jolibois <em.jolibois@gmail.com> * added postgresql+psycopg2 in changes dir * Fixed typo by @samuelcolvin Co-authored-by: Samuel Colvin <samcolvin@gmail.com> * docs: fix typo * chore: sort alphabetically Co-authored-by: Fernando Ike <fernando.ike@maburix.com> Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com> Co-authored-by: Eric Jolibois <em.jolibois@gmail.com> Co-authored-by: Samuel Colvin <samcolvin@gmail.com>

Fernando Ike added 2 commits March 17, 2021 16:27

Added suport to postgresql async driver

d48543a

Added postgres+asyncpg in the doc.

2261570

Added changes file

13b9237

PrettyWood approved these changes Mar 24, 2021

View reviewed changes

PrettyWood added the ready for review label Mar 24, 2021

PrettyWood mentioned this pull request Mar 28, 2021

PostgresDsn driver allowance on scheme #2587

Closed

3 tasks

fike added 2 commits March 31, 2021 13:55

Added postgresql+pg8000 schema

996bf6a

ran make format

12d0352

Kludex approved these changes Mar 31, 2021

View reviewed changes

StephenBrown2 reviewed Mar 31, 2021

View reviewed changes

docs/usage/types.md Outdated Show resolved Hide resolved

Update docs/usage/types.md

dbb27d4

Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com>

PrettyWood requested changes Apr 5, 2021

View reviewed changes

changes/2567-postgres-asyncpg.md Outdated Show resolved Hide resolved

PrettyWood added awaiting author revision awaiting changes from the PR author and removed ready for review labels Apr 5, 2021

fike and others added 6 commits April 5, 2021 12:12

Changed from schema to scheme

8028f9e

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>

Merge branch 'master' of https://github.com/samuelcolvin/pydantic int…

80c855b

…o postgres_asyncpg

fixed typo scheme

6840302

Merge branch 'postgres_asyncpg' of github.com:fike/pydantic into post…

7ca8ffc

…gres_asyncpg

Merge branch 'postgres_asyncpg' of github.com:fike/pydantic into post…

b9cea82

…gres_asyncpg

fixed merge schema

ce07847

fike requested a review from PrettyWood April 6, 2021 02:25

PrettyWood reviewed Apr 6, 2021

View reviewed changes

changes/2567-postgres-asyncpg.md Outdated Show resolved Hide resolved

changed to one line description

51153f2

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>

PrettyWood approved these changes Apr 7, 2021

View reviewed changes

fike added 3 commits April 21, 2021 23:57

Merge branch 'postgres_asyncpg' of github.com:fike/pydantic into post…

4d27663

…gres_asyncpg

Merge branch 'postgres_asyncpg' of github.com:fike/pydantic into post…

9fbb1dd

…gres_asyncpg

added others DBAPI dialects.

9c8d822

PrettyWood reviewed Apr 22, 2021

View reviewed changes

docs/usage/types.md Outdated Show resolved Hide resolved

docs/usage/types.md Outdated Show resolved Hide resolved

docs/usage/types.md Outdated Show resolved Hide resolved

changes/2567-postgres-asyncpg.md Outdated Show resolved Hide resolved

fike and others added 4 commits April 22, 2021 08:57

Added two # by PrettyWood

e63864b

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>

fix typo by PrettyWood

e9013b9

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>

Fixed typo by PrettyWood

c6f1aef

Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>

added postgresql+psycopg2 in changes dir

6a5e335

samuelcolvin reviewed May 9, 2021

View reviewed changes

docs/usage/types.md Outdated Show resolved Hide resolved

github-actions bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels May 9, 2021

github-actions bot assigned fike May 9, 2021

Fixed typo by @samuelcolvin

9a8641e

Co-authored-by: Samuel Colvin <samcolvin@gmail.com>

PrettyWood added 2 commits June 5, 2021 22:15

Merge branch 'master' into postgres_asyncpg

023d6f8

docs: fix typo

ae945bd

PrettyWood requested changes Jun 5, 2021

View reviewed changes

SanchithHegde mentioned this pull request Aug 14, 2021

Migrate to the SQLAlchemy Async API SanchithHegde/decrypto-api#7

Merged

1 task

PrettyWood added 2 commits September 4, 2021 01:04

Merge branch 'master' into postgres_asyncpg

4d37e08

chore: sort alphabetically

d0a5f8d

PrettyWood approved these changes Sep 3, 2021

View reviewed changes

PrettyWood merged commit 1a9f59d into pydantic:master Sep 3, 2021

PrettyWood removed the awaiting author revision awaiting changes from the PR author label Sep 3, 2021

Kludex mentioned this pull request Sep 4, 2021

Allow driver in postgresdsn #2123

Closed

4 tasks

Uh oh!

Support postgresql+asyncpg schema for PostgresDsn #2567

Support postgresql+asyncpg schema for PostgresDsn #2567

Uh oh!

Conversation

fike commented Mar 23, 2021 • edited by PrettyWood Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Summary

Related issue number

Checklist

Uh oh!

codecov bot commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PrettyWood left a comment

Choose a reason for hiding this comment

Uh oh!

Kludex commented Mar 28, 2021

Uh oh!

fike commented Mar 29, 2021

Uh oh!

fike commented Mar 31, 2021

Uh oh!

Uh oh!

PrettyWood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fike commented Apr 6, 2021

Uh oh!

PrettyWood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fike commented Apr 7, 2021

Uh oh!

PrettyWood commented Apr 19, 2021

Uh oh!

fike commented Apr 20, 2021

Uh oh!

PrettyWood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samuelcolvin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samuelcolvin commented May 9, 2021

Uh oh!

fike commented May 9, 2021

Uh oh!

PrettyWood Jun 5, 2021

Choose a reason for hiding this comment

Uh oh!

fike Jul 12, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PrettyWood commented Jun 5, 2021

Uh oh!

fike commented Jul 25, 2021

Uh oh!

PrettyWood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fike commented Mar 23, 2021 •

edited by PrettyWood

Loading

codecov bot commented Mar 23, 2021 •

edited

Loading