-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Dataclasses #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataclasses #269
Conversation
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 12 +1
Lines 1480 1514 +34
Branches 274 280 +6
=====================================
+ Hits 1480 1514 +34 |
305c192 to
cfc7405
Compare
|
ready. @Gaunt @Gr1N @pauleveritt please review and let me know if you see any problems, otherwise I'll merge and deploy in a couple of days. |
cfc7405 to
41439d0
Compare
|
I just noticed |
|
Models using dataclass don't have |
Yes
That's because they return vanilla dataclasses, I want to keep it like that. If you want the serialisation methods user normal models. |
|
Awesome feature! LGTM! |
replaces #231, fixes #178.