Skip to content

Conversation

paxcodes
Copy link
Contributor

@paxcodes paxcodes commented May 28, 2021

Change Summary

Clarify docs about Pydantic's support for custom validation and strict type checking, despite that pydantic is primarily a parsing library.

Content is based on comments by @cknoll [link] and @PyAntony [link) 1

Related issue number

#578

Checklist

  • [n/a] Unit tests for the changes exist
  • [n/a] Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

1: I'd need your email / GitHub-provided no-reply email if you'd like GitHub to recognize you as co-authors of the commit.

@paxcodes paxcodes force-pushed the clarify_docs branch 3 times, most recently from 3f681f0 to 97db4d6 Compare May 28, 2021 22:02
@paxcodes paxcodes marked this pull request as ready for review May 28, 2021 22:09
@paxcodes
Copy link
Contributor Author

paxcodes commented May 28, 2021

please review @PrettyWood

@PrettyWood
Copy link
Collaborator

Please update and rebase/merge with master. Thanks!

@github-actions github-actions bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Jun 4, 2021
@github-actions github-actions bot assigned paxcodes and unassigned samuelcolvin and PrettyWood Jun 4, 2021
paxcodes and others added 4 commits June 12, 2021 11:08
@paxcodes
Copy link
Contributor Author

Please review.

@github-actions github-actions bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels Jul 15, 2021
@github-actions github-actions bot assigned PrettyWood and samuelcolvin and unassigned paxcodes Jul 15, 2021
Copy link
Collaborator

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@PrettyWood PrettyWood merged commit e431604 into pydantic:master Sep 4, 2021
jpribyl pushed a commit to liquet-ai/pydantic that referenced this pull request Oct 7, 2021
* clarify docs on validation and strict type checking

Related: Issue#578

Co-authored-by: cknoll <unknown@exampleemail.com>
Co-authored-by: PyAntony <unknown@exampleemail.com>

* add change.md for PR#2855

* docs: explicitly specify _partial_ support

* chore: update formatting of change description

Co-authored-by: cknoll <unknown@exampleemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants