cast datetime to date in parse_date, #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1515 1517 +2
Branches 280 281 +1
=====================================
+ Hits 1515 1517 +2 |
dhimmel
reviewed
Mar 10, 2022
| @@ -90,7 +90,10 @@ def parse_date(value: Union[date, StrIntFloat]) -> date: | |||
| Raise ValueError if the input isn't well formatted. | |||
| """ | |||
| if isinstance(value, date): | |||
| return value | |||
| if isinstance(value, datetime): | |||
There was a problem hiding this comment.
Note that we might want to update the type hint for value to accept datetime as well.
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
…#298) * combine literal_single_error and literal_multiple_error * cleanup and test union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #295
Checklist
HISTORY.rsthas been updated#<number>@whatever