Added support for Rich Repr protocol #3099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review Not sure if this change warrants any update to the docs. If anything, maybe a sentence or two max, but where? |
|
Thanks so much. When life is less manic I'll review and merge. |
PrettyWood
reviewed
Sep 4, 2021
|
Please update |
github-actions
bot
added
awaiting author revision
Adds code to markdown Co-authored-by: Eric Jolibois <em.jolibois@gmail.com>
|
@PrettyWood Added a Usage with rich page as suggested. Here's what it looks like:
|
PrettyWood
approved these changes
Sep 7, 2021
PrettyWood
removed
the
awaiting author revision
|
Looks great! Thank you 🙏 (big fan of your work btw) |
|
Love rich and pydantic, hope this gets merged! |
|
Great work. Hopefully we'll see this in the next pydantic release? |
|
Thanks so much @willmcgugan, much appreciated. Sorry this has taken so long to get to. |
|
Thanks @samuelcolvin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds support for the Rich Repr Protocol so that Rich can pretty print PyDantic objects.
Note that Rich does not need to be added a dependency. If PyDantic objects are printed with Rich you will get the formatting above, otherwise there are no changes.
Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)