Allow ellipsis on Fields inside Annotated #3133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 25, 2021 18:18
The usecase is TypedDicts, which can't have default values otherwise. Meaning that adding Optionals to Annotated drops them from the list of required fields, which the patch fixes.
Clarifies what's required with TypedDicts schemas.
|
please review. I don't think this needs documentation changes (in fact documentation does not cover not allowing ellipses on annotated fields, since this is an edge case). |
PrettyWood
reviewed
Sep 11, 2021
samuelcolvin
reviewed
Dec 8, 2021
|
please update. |
github-actions
bot
added
awaiting author revision
should be done (dunno how to remove the "needs author revision" tag) |
As per the note in the body of this PR, you can just add "please review". I'm looking now. |
github-actions
bot
added
ready for review
and removed
awaiting author revision
github-actions
bot
assigned
hramezani,
PrettyWood and
samuelcolvin and unassigned
ezegomez
|
Good catch, thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Allow ellipsis on Fields inside Annotated.
The usecase is TypedDicts, which can't have default values otherwise.
Meaning that adding Optionals to Annotated drops them from the list of
required fields, which the patch fixes.
I believe the change is minor enough to not deserve its own issue.
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)