Skip to content

Conversation

tiangolo
Copy link
Contributor

Change Summary

Add section "Based on Pydantic" to docs. Including FastAPI, an API web framework based on Pydantic.


Let me know if it doesn't seem sensible to have a section "Based on Pydantic".

Also, let me know if I'm being too verbose and you would prefer just a list of links with each third party (just FastAPI for now).

Related issue number

No relevant issue.

Performance Changes

Just docs.

pydantic cares about performance, if there's any risk performance changed on this PR,
please run make benchmark-pydantic before and after the change:

  • before: ?
  • after: ?

Checklist

  • [n/a] Unit tests for the changes exist
  • [n/a] Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes
  • [n/a] No performance deterioration (if applicable)
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • if you're not a regular contributer please include your github username @whatever

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #323 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #323   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines        1771   1771           
  Branches      344    344           
=====================================
  Hits         1771   1771

@samuelcolvin
Copy link
Member

Happy to have such a section but like aiohttp I think it should be one line per library.

@tiangolo
Copy link
Contributor Author

Sure. Done ✔️

@samuelcolvin
Copy link
Member

Sorry, forgot to say: no need for a release. I can update the docs without releasing the python package.

@tiangolo
Copy link
Contributor Author

Cool. Sure.

@samuelcolvin samuelcolvin merged commit 96020e9 into pydantic:master Dec 23, 2018
@tiangolo
Copy link
Contributor Author

Thanks! 🎉

@tiangolo tiangolo deleted the fastapi branch December 23, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants