prevent validators being called repeatedly after inheritance #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
force-pushed
the
validator-inheritance
branch
from
5636bb9 to
4d283a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 1771 1773 +2
Branches 344 345 +1
=====================================
+ Hits 1771 1773 +2 |
5 tasks
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* WIP serialization * minor performane tweaks * adding any serializer * any serializer working * trying common serializer * working on tuple impl * working on include/exclude on lists * fixing tuple serializer * removing common from serializers * rename list -> list_tuple * fixing core_schema, startin tests * improving any serializer * getting fallback to work * renaming tests to aid benchmark comparison * tests for list/tuple include/exclude * WIP warn on fallback * fallback warnings working * restructure serializers * functional serializers working * errors in functions * adding float, bool and none serializers * remove to_python_json * optimise simple serializers * correctly handling subclass of basic types * tests for Enums * rename format -> mode * format serializer * support dicts * more tests for dicts * error message compatibility with pypy * bytes serializer * fix bytes decoding errors * add base64 encoding for bytes * validation serialization schema * set and frozenset * rename alias -> validation_alias * WIP TypedDict * simplifying definition-time include/exclude schema * fixing include/exclude on lists and tuples * use newer include/exclude logic for dicts * filtering of type_dict working * by_alias for typed_dicts * maintain import order for typed_dict * adding new-class * support exclude_defaults * exclude_unset support * fix on PyPy * add some benchmarks * support datetime, date and time * datetime parsing support * improve coverate rename datetime -> datetime_etc * add support for urls * support positional tuples * functional test for positional tuples * fix recursion guard * support JSON type and round_trip argument * simplify combined_serializer * cleanup imports * add some other serializer builders * support literals * fix pyright error * support recursive model serialization * tweaking recursion guard * adding generator * generator generator type * fix build * refactor serializers * ser config * move bytes base64 to config * tweak into_slots names * IncEx as a trait * fixing include/exclude in any serializers * filtering in any in json * rename "inc_ex" to filter * dataclass any serialization * test dataclass serialization * any pydantic model serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was introduced in #320 I believe.
Checklist
HISTORY.rsthas been updated#<number>@whatever