Fix BaseConfig max_anystr_length default to fixed number to None #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 1824 1824
Branches 356 356
=====================================
Hits 1824 1824 |
|
I agree. The original rationale was to avoid dos like attacks by avoiding someone submitting |
|
Awesome, thanks! |
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* add docstrings and docstring tests * account for multiple matches * update test_docstrings * improve test * fix * address comments * address comments * Update pydantic_core/core_schema.py Co-authored-by: Samuel Colvin <s@muelcolvin.com> * Update pydantic_core/core_schema.py Co-authored-by: Samuel Colvin <s@muelcolvin.com> * Update pydantic_core/core_schema.py Co-authored-by: Samuel Colvin <s@muelcolvin.com> * Update pydantic_core/core_schema.py Co-authored-by: Samuel Colvin <s@muelcolvin.com> * Update pydantic_core/core_schema.py Co-authored-by: Samuel Colvin <s@muelcolvin.com> * Update pydantic_core/core_schema.py Co-authored-by: Samuel Colvin <s@muelcolvin.com> * Update pydantic_core/core_schema.py Co-authored-by: Samuel Colvin <s@muelcolvin.com> * Update pydantic_core/core_schema.py Co-authored-by: Samuel Colvin <s@muelcolvin.com> * move ref * fix lint Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Make
BaseConfigby default havemin_anystr_lengthandmax_anystr_lengthset toNone.All the discussion/motivation is in issue #349 .
Related issue number
#349
Checklist
HISTORY.rsthas been updated#<number>@<whomever>