Skip to content

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jan 26, 2019

Related issue number

fix #372, fix #366, fix #245, fix #280.

ref python/mypy#6251 and python/mypy#6239

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

@samuelcolvin
Copy link
Member Author

should probably merge other PRs before this to avoid them conflicting.

@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #373   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        1934   1999   +65     
  Branches      375    375           
=====================================
+ Hits         1934   1999   +65

@samuelcolvin samuelcolvin merged commit 9ef4018 into master Feb 4, 2019
@samuelcolvin samuelcolvin deleted the typing branch February 4, 2019 21:54
@samuelcolvin samuelcolvin mentioned this pull request Feb 12, 2019
4 tasks
alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
* fix is_enum as per PyO3/pyo3#2905

* only check is_enum on first loop

* logic for pypy 3.7 & 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant