Skip to content

custom validators in schema #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2019
Merged

custom validators in schema #375

merged 2 commits into from
Jan 30, 2019

Conversation

tiangolo
Copy link
Contributor

@tiangolo tiangolo commented Jan 29, 2019 •
edited
Loading

Change Summary

Test NoneType directly in Field.include_in_schema and add test for validator decorator

Related issue number

Issue #363

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

@codecov
Copy link

codecov bot commented Jan 29, 2019 •
edited
Loading

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #375   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        1894   1894           
  Branches      369    369           
=====================================
  Hits         1894   1894

tiangolo
tiangolo commented Jan 29, 2019
View reviewed changes
Copy link
Contributor Author

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question/check.

@tiangolo tiangolo mentioned this pull request Jan 29, 2019
Closed
@samuelcolvin samuelcolvin changed the title Fix for #363 custom validators in schema Jan 29, 2019
@tiangolo
Copy link
Contributor Author

I just rebased and force pushed to solve the conflicts. This is ready for your review @samuelcolvin .

@samuelcolvin samuelcolvin merged commit 725e86a into pydantic:master Jan 30, 2019
@tiangolo tiangolo deleted the issue-363 branch January 30, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiangolo @samuelcolvin