Skip to content

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Feb 6, 2019

Change Summary

Before now, you either had to use all or none of values, field and config extra arguments on validators. This fixes that by allowing any combination of the arguments to be used.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #388 into master will decrease coverage by 1.62%.
The diff coverage is 54.28%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage     100%   98.37%   -1.63%     
==========================================
  Files          14       14              
  Lines        2000     2034      +34     
  Branches      375      410      +35     
==========================================
+ Hits         2000     2001       +1     
- Misses          0       22      +22     
- Partials        0       11      +11

@pydantic pydantic deleted a comment from codecov bot Feb 8, 2019
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #388   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        2000   2031   +31     
  Branches      375    409   +34     
=====================================
+ Hits         2000   2031   +31

@samuelcolvin samuelcolvin changed the title WIP rebuild validator arguments rebuild validator arguments Feb 8, 2019
@samuelcolvin samuelcolvin merged commit baade9a into master Feb 13, 2019
@samuelcolvin samuelcolvin deleted the validator-args branch February 13, 2019 10:31
alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
* Update pyo3 to 0.18.1

* Remove pytest.mark.xfail

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant