Fix the type hint of ValidationError.json #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the json.dumps documentation.
|
Not sure if this would be worth mentioning in HISTORY (I would think not). |
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 2068 2068
Branches 420 420
=====================================
Hits 2068 2068 |
|
I agree, but we tend to put everything in history.
…On Mon, 25 Feb 2019, 15:07 codecov[bot], ***@***.***> wrote:
Codecov
<https://codecov.io/gh/samuelcolvin/pydantic/pull/406?src=pr&el=h1> Report
Merging #406
<https://codecov.io/gh/samuelcolvin/pydantic/pull/406?src=pr&el=desc>
into master
<https://codecov.io/gh/samuelcolvin/pydantic/commit/e77bc00d6e52a4ea13fb467c163ca67468c7d02c?src=pr&el=desc>
will *not change* coverage.
The diff coverage is 100%.
@@ Coverage Diff @@## master #406 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 2068 2068
Branches 420 420
=====================================
Hits 2068 2068
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#406 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD2jGeAm6zcmVWlqCciw5noMf3Vu_HpJks5vQ_xAgaJpZM4bQEtw>
.
|
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* adding definitions support * fix rust benchmarks * rename "recursive" -> "definition" * in-line some valdiators * error positions for definitions errors * inlining, take 3 * cleanup * correctly inline serializers * switch to defintions as a core schema type * errors on repeated refs, more tests * Fix benches * Update src/build_context.rs * Add metadata and serialization to definitions schema --------- Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the json.dumps documentation.
Change Summary
This changes the type hint of
indentto accept any ofNone,intandstrin accordance with the documentation ofjson.dumps.Related issue number
Checklist
HISTORY.rsthas been updated#<number>@<whomever>