Resolve ForwardRef on Field.outer_type_ #4249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When resolving
ForwardRefs, theField.outer_type_is not resolved, onlyField.type_. This PR updatesupdate_field_forward_refsto resolve both attributes, while still only callingField.prepareonce.Field.outer_type_can be a nested object (eg:List[str], etc), but I only check if the entire annotation is aForwardReffor simplicity. This should cover most cases, namely:from __future__ import annoationsannotations"List[RecursiveType]"will be resolved,List["RecursiveType"]will not)I think I've seen other instances where
ForwardRefsinside nested types aren't full resolved, so 🤞 this is fine for now.Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)