Fix imports indirectly from pydantic typing

[aminalaee]

Change Summary

Some imports indirectly get ForwardRef and other types from .typing instead of typing module. I came across this when I was working on something else.

Closes #4182

Related issue number

None

Checklist

• Unit tests for the changes exist
• Tests pass on CI and coverage remains at 100%
• Documentation reflects the changes where applicable
• changes/<pull request or issue id>-<github username>.md file added describing change
  (see changes/README.md for details)
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

[aminalaee]

This will also close #4182 to keep consistency in pydantic.typing.__all__

[samuelcolvin]

This will also close #4182 to keep consistency in pydantic.typing.__all__

Thanks, if this is closing issues, please put them in the PR body so they get auto-closed.

Please update.

[aminalaee]

please review

[hramezani]

Thanks @aminalaee for the patch 👍

There are some other ForwardRef that can be replaced:

• pydantic/tests/test_forward_ref.py

  Line 84 in 11d8589

  from pydantic.typing import ForwardRef

• There are some tests that have from pydantic.typing import ForwardRef that can be replaced by from typing import ForwardRef:

  pydantic/tests/test_forward_ref.py

  Lines 90 to 96 in 11d8589

  	def test_basic_forward_ref(create_module):
  	@create_module
  	def module():
  	from typing import Optional
  	from pydantic import BaseModel
  	from pydantic.typing import ForwardRef

[hramezani]

please update

[aminalaee]

Thank you for the review @hramezani . I'd only checked the top imports, this should be ok now. please review.

[hramezani]

Thanks @aminalaee for the update 👍

[samuelcolvin]

Hi @aminalaee please update to add a change file.

Otherwise LGTM.

[aminalaee]

Sorry I'd forgotten to add that. please review again.

[samuelcolvin]

Thanks so much.