Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __post_init_post_parse__ is incorrectly passed keyword arguments when no __post_init__ is defined #4361

merged 1 commit into from Aug 11, 2022


Copy link

@hramezani hramezani commented Aug 9, 2022

Change Summary

Related issue number

fix #4342


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/ for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link
Member Author

please review

pydantic/ Outdated Show resolved Hide resolved
Copy link

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @PrettyWood if you're happy please merge.

@hramezani please remember "fix" in the PR body so the issue get's closed, otherwise I'll forget.

@PrettyWood PrettyWood merged commit 149c05b into pydantic:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

__post_init_post_parse__ is incorrectly passed keyword arguments when no __post_init__ is defined
3 participants