feat: add SecretStr and SecretBytes. #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samuelcolvin is this better? |
|
Looks like you've changed the permissions on lots of files Maybe you could set back to 644? |
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 2188 2220 +32
Branches 435 435
=====================================
+ Hits 2188 2220 +32 |
samuelcolvin
reviewed
Apr 2, 2019
Atheuz
force-pushed
the
add-secret-types2
branch
from
e485d56 to
d7845a4
Compare
|
@samuelcolvin fixed the issues you brought up, but didn't know about the format thing you mentioned. |
Atheuz
force-pushed
the
add-secret-types2
branch
2 times, most recently
from
af54f96 to
fec9a1e
Compare
Atheuz
force-pushed
the
add-secret-types2
branch
from
fec9a1e to
6372516
Compare
|
@samuelcolvin are we mergable yet? |
|
Just waiting for a response from @tiangolo, on the question above, I've done some research but not entirely clear. Is this particularly urgent for you? |
|
Sorry for the delay guys. I hadn't seen the notification. I added my comment in the conversation above. |
|
thanks @tiangolo, much appreciated. No problem on the slight delay, still better than the response time for most paid services. :-) |
…ere is no bytes type in json.
tiangolo
suggested changes
Apr 4, 2019
tiangolo
suggested changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added SecretStr and SecretBytes.
Related issue number
#443
Checklist
HISTORY.rsthas been updated