Skip to content

Conversation

mgu
Copy link
Contributor

@mgu mgu commented Jun 12, 2017

No description provided.

@samuelcolvin
Copy link
Member

Awsome, thank you. What are the results?

@mgu
Copy link
Contributor Author

mgu commented Jun 12, 2017

trafaret   best=1.391s, avg=1.402s, stdev=0.013s
drf        best=6.006s, avg=6.153s, stdev=0.183s
pydantic   best=0.678s, avg=0.694s, stdev=0.014s

:)

@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         701    701           
  Branches      156    156           
=====================================
  Hits          701    701

@samuelcolvin
Copy link
Member

wow, that's not great of drf. But having read its code in the past it, it does masses of checking that it's configured right and calls out to slow django standard methods.

I'll have a play with it later and merge.

@mgu
Copy link
Contributor Author

mgu commented Jun 12, 2017

ok, thanks

@samuelcolvin
Copy link
Member

Looks good. I'm shocked by the performance gap.

I'll try to add a few more popular packages and then perhaps add a graph of relative performance to the docs.

@samuelcolvin samuelcolvin merged commit 8364a6b into pydantic:master Jun 12, 2017
@ybressler
Copy link
Contributor

This PR is a top result for a google search on "Pydantic + DRF" >> perhaps we can create a ticket to describe the benchmark on Pydantic's documentation? Additionally, it would be helpful to have some guidance on how the frameworks compare to each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants