Skip to content

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jun 4, 2019

Change Summary

support dumping dataclasses to JSON by modifying pydantic_encoder.

Related issue number

replace #528

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #575 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #575   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2495   2498    +3     
  Branches      498    499    +1     
=====================================
+ Hits         2495   2498    +3

@samuelcolvin samuelcolvin merged commit 9ffa311 into master Jun 4, 2019
@samuelcolvin samuelcolvin deleted the dataclasses-json branch June 4, 2019 16:06
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #575 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #575   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2495   2498    +3     
  Branches      498    499    +1     
=====================================
+ Hits         2495   2498    +3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant